Skip to content

Fix tapping on non-textual block may trigger an error#420

Closed
daniloercoli wants to merge 2 commits intorelease/0.3from
issue/415-Tapping-on-non-textual-block-may-trigger-an-error
Closed

Fix tapping on non-textual block may trigger an error#420
daniloercoli wants to merge 2 commits intorelease/0.3from
issue/415-Tapping-on-non-textual-block-may-trigger-an-error

Conversation

@daniloercoli
Copy link
Copy Markdown
Contributor

This PR fixes #415 by making sure there is at least one Textual block in the list, before applying the hack about the keyboard hiding in the alpha release.

Steps to repro:

  • Start the demo app
  • Tap on a para block
  • Tap on the page break block
  • The block holder is selected, but the soft keyboard is still up, and the caret blinking in the previous para block
  • If you tap on the keyboard characters are inserted in the para block

Important test

  • Start the demo app with empty content
  • Tap on '+' symbol and add a page break
  • Tap on the page break block and see there is no error

Repeat the steps above by selecting other kind of blocks

@daniloercoli daniloercoli added this to the Alpha milestone Dec 20, 2018
@daniloercoli daniloercoli requested review from koke and mzorz December 20, 2018 16:44
@daniloercoli
Copy link
Copy Markdown
Contributor Author

Closing in favor of #423 due to the reasons expressed in #423 (comment)

@SergioEstevao SergioEstevao deleted the issue/415-Tapping-on-non-textual-block-may-trigger-an-error branch November 8, 2019 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant