iOS Only - Re-arrange scroll position of text inputs on landscape mode#397
Merged
iOS Only - Re-arrange scroll position of text inputs on landscape mode#397
Conversation
Contributor
Author
|
@marecar3 I've updated the import with this PR that you mentioned in #387 (comment) I've already tested it with WP-Android but feel free to test it yourself, it'd be nice to have a double check. |
pinarol
commented
Dec 18, 2018
| */ | ||
| import { FlatList, KeyboardAvoidingView } from 'react-native'; | ||
| import { FlatList } from 'react-native'; | ||
| import KeyboardAvoidingView from '../components/keyboard-avoiding-view'; |
Contributor
|
Thanks for tackling this @pinarol! One minor thing that I noticed: can we add the same width/color border on the left/right sides, regardless of orientation? |
Contributor
Author
|
@iamthomasbishop I've opened a new issue to address that #402 I am not sure that's a simple bug to fix within this PR but I'll try to fix that as my next task. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-arranges the scrolling offset of text inputs for landscape mode.
We are showing the inner toolbar in portrait mode but in landscape mode we don't have room for it so we won't show that.
Before:
After:
Fixes part of #197
To Test
Test 1 - Landscape mode
Test 2 - Portait mode