Skip to content

Update forked dependency to fix typescript error#3892

Merged
guarani merged 2 commits intodevelopfrom
fix/typescript-version-in-forked-dependency
Aug 31, 2021
Merged

Update forked dependency to fix typescript error#3892
guarani merged 2 commits intodevelopfrom
fix/typescript-version-in-forked-dependency

Conversation

@guarani
Copy link
Copy Markdown
Contributor

@guarani guarani commented Aug 31, 2021

To test, see WordPress/gutenberg#34422

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@guarani guarani enabled auto-merge August 31, 2021 17:59
@guarani guarani disabled auto-merge August 31, 2021 20:09
@guarani
Copy link
Copy Markdown
Contributor Author

guarani commented Aug 31, 2021

👋 @mchowning, could I ask you for a review here please? It's pointing to Gutenberg commit WordPress/gutenberg@29f73f0, which is a commit on trunk just after the merge commit of the linked Gutenberg PR.

@guarani guarani requested a review from mchowning August 31, 2021 20:10
Copy link
Copy Markdown
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guarani guarani merged commit 3458ea3 into develop Aug 31, 2021
@guarani guarani deleted the fix/typescript-version-in-forked-dependency branch August 31, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Tooling [Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants