Skip to content

[Embed block] Fix content disappearing on Android when switching light/dark mode#3859

Merged
fluiddot merged 12 commits intodevelopfrom
embed-block-fix-android-dark-mode
Sep 9, 2021
Merged

[Embed block] Fix content disappearing on Android when switching light/dark mode#3859
fluiddot merged 12 commits intodevelopfrom
embed-block-fix-android-dark-mode

Conversation

@fluiddot
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot commented Aug 20, 2021

gutenberg PR: WordPress/gutenberg#34207

Fixes #3855 but it's not the optimal solution, it would be nice to investigate this further.

To test:
Follow testing instructions from gutenberg PR: WordPress/gutenberg#34207.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Sep 3, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Copy Markdown
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fluiddot fluiddot added this to the 1.62.0 (18.3) milestone Sep 9, 2021
@fluiddot fluiddot enabled auto-merge September 9, 2021 08:08
@fluiddot
Copy link
Copy Markdown
Contributor Author

fluiddot commented Sep 9, 2021

I noticed that the Check Correctness CI check was failing due to changes in the package-lock.json file, I ran locally the command npm install and pushed the changes for that file in this commit.

@fluiddot fluiddot merged commit 3cdad33 into develop Sep 9, 2021
@fluiddot fluiddot deleted the embed-block-fix-android-dark-mode branch September 9, 2021 11:54
@enejb enejb mentioned this pull request Sep 17, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Embed block [Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Embed block] Fix issues related to content disappearing on Android

2 participants