Skip to content

Fix undo/redo on new Para/Heading blocks#361

Merged
daniloercoli merged 2 commits intomasterfrom
issue/360-fix-undo-redo-new-block
Dec 12, 2018
Merged

Fix undo/redo on new Para/Heading blocks#361
daniloercoli merged 2 commits intomasterfrom
issue/360-fix-undo-redo-new-block

Conversation

@daniloercoli
Copy link
Copy Markdown
Contributor

This PR fixes a problem with undo/redo not working on new (empty) blocks after writing some text.
Fixes #360

GB side PR: WordPress/gutenberg#12815

Steps to test:

  • Create a new post
  • Start a paragraph
  • Type hello
  • Tap undo: it should go back to an empty paragraph
  • Tap undo: paragraph removed
  • Tap redo: empty paragraph restored
  • Tap redo: "hello" restored

Note: The cursor is not restored to the correct position at the last step. we have another PR open for this: #309

@daniloercoli daniloercoli added the [Type] Bug Something isn't working label Dec 12, 2018
@daniloercoli daniloercoli added this to the Alpha milestone Dec 12, 2018
@daniloercoli daniloercoli requested review from koke and mzorz December 12, 2018 15:27
Copy link
Copy Markdown
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, worked 👌

@daniloercoli daniloercoli merged commit 83cd3eb into master Dec 12, 2018
@daniloercoli daniloercoli deleted the issue/360-fix-undo-redo-new-block branch December 12, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants