Try to fix RN0.64 upgrade WPAndroid insert link crash#3597
Try to fix RN0.64 upgrade WPAndroid insert link crash#3597
Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
Tried the WPAndroid installable build built off c727eff and it doesn't crash for me when trying to add a link inside a paragraph by tapping on the link toolbar button! 🎉 |
|
Installable build still works ok (smoke testing) after all the deps updates. At this point @ceyhun , I think we can consider merging the all the "extra PRs" into the main 0.64 upgrade PRs, let me know what you think. |
Android Writing Flow checklistAndroid 11, physical Pixel 2XL - using WPAndroid installable build 109148, Gutenberg hash WordPress/gutenberg@a6ce908. General
Rich Text Format
Splitting and merging
Undo / Redo - Test Cases
|
371fb77 to
af16d2c
Compare
iOS Writing Flow checklistiOS 14.4, physical iPhone XR - using WordPress iOS installable build 50172 General
Rich Text Format
Splitting and merging
Undo / Redo - Test Cases
|
|
The failed Check Correctness job (with a lint issue with |
|
Fix has been included in the main RN 0.64 upgrade PRs already and those got merged already so, closing this 🎉. |
Fixes #
Gutenberg PR: WordPress/gutenberg#32517
WPAndroid PR: wordpress-mobile/WordPress-Android#14802
To test:
PR submission checklist: