Skip to content

Updates Android Gradle Plugin to 4.0.2#3542

Merged
antonis merged 1 commit intodevelopfrom
update-agp-to-4.0.2
Jun 1, 2021
Merged

Updates Android Gradle Plugin to 4.0.2#3542
antonis merged 1 commit intodevelopfrom
update-agp-to-4.0.2

Conversation

@antonis
Copy link
Copy Markdown

@antonis antonis commented May 24, 2021 •
edited
Loading

gutenberg PR: WordPress/gutenberg#32144

To test:
Run an Android composite build with gutenberg-mobile:

  1. Open the WordPress-Android project
  2. Set your gutenberg-mobile path (localGutenbergMobilePath) at local-builds.gradle
  3. Reload Gradle project and run
  4. Verify that no Gradle error occurs due to version mismatch

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@antonis antonis mentioned this pull request May 24, 2021
Merged
7 tasks
@antonis antonis marked this pull request as ready for review May 24, 2021 09:34
@antonis antonis requested a review from oguzkocer May 24, 2021 09:44
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented May 25, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@oguzkocer
Copy link
Copy Markdown
Contributor

oguzkocer commented May 26, 2021

@antonis I've approved the changes in Gutenberg, but I think you'll need from a core contributor to get that merged in. Once that's done and this PR is updated, I am happy to review & merge this in, but I'd feel more comfortable if someone else from the gutenberg-mobile team can take care of it.

@antonis antonis requested a review from chipsnyder May 26, 2021 20:55
@jd-alexander
Copy link
Copy Markdown
Contributor

jd-alexander commented May 27, 2021

Thanks for creating this PR @antonis 🥳 I was attempting to utilize the composite build during development and I was getting failures with dependencies due to the gradle plugin version mismatch.

@antonis antonis requested a review from geriux May 27, 2021 07:50
@mkevins mkevins self-requested a review June 1, 2021 06:37
mkevins
mkevins approved these changes Jun 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this Antonis! Let's resolve the conflicts and then merge. 👍

@antonis antonis force-pushed the update-agp-to-4.0.2 branch from 474e066 to a27792c Compare June 1, 2021 07:22
@antonis antonis enabled auto-merge (squash) June 1, 2021 07:35
@antonis antonis merged commit 8d33bc3 into develop Jun 1, 2021
@antonis antonis deleted the update-agp-to-4.0.2 branch June 1, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oguzkocer oguzkocer Awaiting requested review from oguzkocer

@chipsnyder chipsnyder Awaiting requested review from chipsnyder

@geriux geriux Awaiting requested review from geriux

1 more reviewer

@mkevins mkevins mkevins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antonis @oguzkocer @jd-alexander @mkevins