Enable reusable block only in WP.com sites#3490
Merged
Conversation
7 tasks
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
# Conflicts: # gutenberg
This was referenced May 12, 2021
Merged
# Conflicts: # bundle/ios/App.js # bundle/ios/App.js.map # bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/en-gb.json # bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/nl.json # bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/ro.json # bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/sv.json
# Conflicts: # bundle/ios/App.js # bundle/ios/App.js.map
Contributor
|
Hey there @fluiddot 👋 We'll be cutting the 1.53.0 release some time soon today. I'm bumping this PR to 1.54.0 milestone, please let us know if it needs to make it into 1.53.0 instead. |
This was referenced May 14, 2021
jd-alexander
approved these changes
May 17, 2021
Contributor
jd-alexander
left a comment
There was a problem hiding this comment.
Approved via WordPress/gutenberg#31744 (review)
# Conflicts: # bundle/android/strings.xml # bundle/ios/App.js # bundle/ios/App.js.map # bundle/ios/GutenbergNativeTranslations.swift # bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/en-za.json # bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/it.json # bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/sq.json
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gutebergPR: WordPress/gutenberg#31744WordPress-iOSPR: wordpress-mobile/WordPress-iOS#16475WordPress-AndroidPR: wordpress-mobile/WordPress-Android#14623Why reusable block is disabled in self-hosted sites
Related issue: #3457
The main reason for disabling this block in self-hosted sites is related to the case of having a reusable block that contains a self-reference (a reference to the same reusable block). While in WP.com sites this is working properly, in self-hosted sites, fetching data from the endpoint that holds the data for reusable blocks (
/wp-json/wp/v2/blocks) in this case, the site returns a bad response so we don't have data for displaying them.NOTE: This is reproducible on self-hosted sites with and without Jetpack, although the error response is different.
To test:
Follow the testing instructions from
gutenbergPR.PR submission checklist: