Dismiss keyboard when non-textual block is selected#341
Merged
daniloercoli merged 1 commit intomasterfrom Dec 10, 2018
Merged
Conversation
This was referenced Dec 10, 2018
mzorz
approved these changes
Dec 10, 2018
Contributor
mzorz
left a comment
There was a problem hiding this comment.
LGTM 👍 remember to update the hashes once Gutenberg-side PR gets merged
This was referenced Dec 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #308 by making sure that to call blur on the textual field that lost the focus.
React Native Aztec Wrapper PR is here:wordpress-mobile/react-native-aztec#93
GB side PR: WordPress/gutenberg#12765
Steps to repro:
Note: The caret is still visible (and blinking) in the TextInput "powered" block that lost the focus. We will fix this in another PR.