Image Block: Improve Text Entry for Long Alt Text#3236
Merged
Conversation
This commit updates the Gutenberg reference to include the latest changes.
7 tasks
This commit updates the reference to Gutenberg to include the latest changes.
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
guarani
approved these changes
Mar 10, 2021
Contributor
guarani
left a comment
There was a problem hiding this comment.
This looks good! I approved the GB pr here: WordPress/gutenberg#29670 (review)
If no further changes are needed design-wise, I think this is ready to merge (you'll have to add something to the release notes here, too!)
Contributor
|
GitHub reports that Edit: it did fix the complain, and the diff is still correct (only change to the Gutenberg hash, pointing to WordPress/gutenberg@c508c1b as it needs to so, all good 👍. Will enable "merge when CI green". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #922
gutenberg: WordPress/gutenberg#29670Description
With this PR, a new
AltTextSettingscomponent has been introduced to replace the currentTextControlthat exists for entering an image's Alt text. This new component makes use ofBottomSheet.SubSheetso that users are taken to a new subsheet when entering alt text.The end goal is to provide a better experience for users who are entering a longer alt text for their images, as the current text entry has limited room/options for scrolling.
How has this been tested?
The general steps for testing, for both iOS and Android, are as follows:
As this is a UI change, I have also tested with dark mode enabled and in landscape mode.
Please see Gutenberg PR for additional details, screenshots, and comments.
PR submission checklist: