Fix missing context prop in BlockEdit component#3208
Conversation
There was a problem hiding this comment.
Approved via WordPress/gutenberg#29479.
Looks like iOS file test failed on first attempt, but I think it was just a flake, as I tested the file block on iOS and the file test passed when I enabled full suite of tests.
Let's see if test passes on second attempt after restart. If that passes we'll be ready to merge after updating the gutenberg ref 👍
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
All the tests passed so I'm going to update the Gutenberg reference with the merge commit from |
|
Should this change make it into 1.48.0 ? release |
This fix is only required to be included if we include the changes from the Gutenberg PR that introduced the bug. I see that the release was branched off from a commit before that one so it's not needed, thanks for the heads-up 🙇 . |
Hi @cameronvoell Just to chime in here, did you by any chance have a look at the error log for this failure? Because I utilized sleep calls to ensure that the media picker bottom sheet is shown before making a selection and it was flaky in the past but I thought it was resolved now. I also know that other issues have been taking place in the UI tests, so I want to assist in any way possible to reduce the flakiness, as I know it impacts developer productivity. |

gutenbergPR: WordPress/gutenberg#29479Fixes WordPress/gutenberg#29471
To test:
Instructions are described in the the "How has this been tested?" section of the Gutenberg PR.
PR submission checklist: