Skip to content

Audio Block - Audio Player UI #3037

Closed
jd-alexander wants to merge 22 commits intodevelopfrom
add/audio-block-II-audio-player-ui
Closed

Audio Block - Audio Player UI #3037
jd-alexander wants to merge 22 commits intodevelopfrom
add/audio-block-II-audio-player-ui

Conversation

@jd-alexander
Copy link
Copy Markdown
Contributor

@jd-alexander jd-alexander commented Jan 21, 2021 •
edited by ceyhun
Loading

Gutenberg WordPress/gutenberg#27467
WPAndroid wordpress-mobile/WordPress-Android#13843
WPiOS wordpress-mobile/WordPress-iOS#15694
To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

This was referenced Jan 21, 2021
Closed
Merged
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 22, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ceyhun ceyhun mentioned this pull request Jan 22, 2021
Closed
3 tasks
@ceyhun ceyhun added this to the 1.46 (16.7) milestone Jan 29, 2021
@fluiddot
Copy link
Copy Markdown
Contributor

fluiddot commented Feb 1, 2021

👋 @jd-alexander, we're cutting the release now, however since this PR will be included in the release I'll leave it in the current milestone. Once it's merged please let me know and I'll cherry pick the changes in the release branch, thanks!

@jd-alexander
Copy link
Copy Markdown
Contributor Author

jd-alexander commented Feb 1, 2021

👋 @jd-alexander, we're cutting the release now, however since this PR will be included in the release I'll leave it in the current milestone. Once it's merged please let me know and I'll cherry pick the changes in the release branch, thanks!

Thanks @fluiddot I will keep you updated.

@jd-alexander jd-alexander requested a review from ceyhun February 1, 2021 14:51
@jd-alexander
Copy link
Copy Markdown
Contributor Author

jd-alexander commented Feb 1, 2021

The changes that this PR reference were merged in via WordPress/gutenberg#27467 We are closing this PR in favor of #3070 that also contains a reference to enabling this block in production.

@fluiddot
Copy link
Copy Markdown
Contributor

fluiddot commented Feb 1, 2021

The changes that this PR reference were merged in via WordPress/gutenberg#27467 We are closing this PR in favor of #3070 that also contains a reference to enabling this block in production.

I'll remove it from the milestone too.

@fluiddot fluiddot removed this from the 1.46 (16.7) milestone Feb 1, 2021
@mzorz mzorz mentioned this pull request Feb 2, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ceyhun ceyhun Awaiting requested review from ceyhun

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jd-alexander @fluiddot @ceyhun