Skip to content

Use react-native-url-polyfill in globals#2923

Merged
mkevins merged 10 commits intodevelopfrom
try/polyfill-url-search
Jan 8, 2021
Merged

Use react-native-url-polyfill in globals#2923
mkevins merged 10 commits intodevelopfrom
try/polyfill-url-search

Conversation

@mkevins
Copy link
Copy Markdown
Contributor

@mkevins mkevins commented Dec 22, 2020 •
edited
Loading

Fixes #2922

Related PR

gutenberg: WordPress/gutenberg#27867

Steps to test

  1. Create a new post or page (on a site with some published posts and pages)
  2. Add a button block
  3. Edit the link in the button block
  4. Tap "Search or type URL" to open link picker
  5. Begin typing a few characters and wait for the results
  6. Erase the search a type a few different characters

Expected behavior
The results should be different for searches which have differerent queries. The search results should reflect the query being searched for.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@mkevins mkevins added the bugfix label Dec 22, 2020
@mkevins mkevins mentioned this pull request Dec 22, 2020
Closed
6 tasks
@mkevins mkevins requested review from Tug and enejb December 22, 2020 02:36
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Dec 22, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@mkevins mkevins marked this pull request as ready for review December 22, 2020 02:47
@mkevins mkevins marked this pull request as draft December 22, 2020 11:21
@mkevins mkevins mentioned this pull request Dec 23, 2020
Merged
6 tasks
@mkevins mkevins changed the title Add simple patch for URL search getter Use react-native-url-polyfill in globals Dec 23, 2020
@mkevins mkevins marked this pull request as ready for review December 23, 2020 03:13
enejb
enejb approved these changes Jan 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change set worked well for me. Thanks for the fixes!

@enejb enejb force-pushed the try/polyfill-url-search branch from bbf660d to 73f9da2 Compare January 6, 2021 23:32
@mkevins mkevins force-pushed the try/polyfill-url-search branch from 73f9da2 to 228d56b Compare January 7, 2021 02:33
@mkevins mkevins force-pushed the try/polyfill-url-search branch from abc23b1 to 96a9cc4 Compare January 7, 2021 22:03
@mkevins mkevins merged commit cbb5b9f into develop Jan 8, 2021
@mkevins mkevins deleted the try/polyfill-url-search branch January 8, 2021 00:40
@mkevins mkevins mentioned this pull request Jan 8, 2021
Merged
2 tasks
@cameronvoell cameronvoell mentioned this pull request Jan 19, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enejb enejb enejb approved these changes

@Tug Tug Awaiting requested review from Tug

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

api-fetch query parameters are dropped

2 participants

@mkevins @enejb