Make block holder and toolbar look nicer#286
Merged
Conversation
This replaces the icons with dashicons, tweaks the layout to be closer to the designs, and removes the unused settings button.
Contributor
|
Adding @iamthomasbishop. |
Member
Author
|
After talking to Thomas, I still have to:
|
This imports a color palette taken from calypso instead of the Gutenberg one
Member
Author
|
This needs WordPress/gutenberg#12403 to be merged first |
Member
Author
|
Ready for another look:
|
We're skipping WordPress/gutenberg#12403 for now
This was referenced Nov 29, 2018
marecar3
approved these changes
Nov 30, 2018
|
|
||
| import styles from './style.scss'; | ||
|
|
||
| export default class InlineToolbarButton extends React.Component<PropsType> { |
Contributor
There was a problem hiding this comment.
Hey @koke, did you maybe consider using ToolbarButton e.g.<ToolbarButton label={ __( 'Undo' ) } icon="undo" isDisabled={ ! hasUndo } onClick={ undo } /> ?
As it's the same as what you have created here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This needs WordPress/gutenberg#12403 to be merged first
Some changes to make the block holder look better:
@iamthomasbishop I know your mockups use Gridicons, but we still don't have those available, and dashicons are already quite an improvement over emoji 😉. Also, I used
$light-gray-500for the block borders, but I'm not sure if it's the right one, I think your mockups looked more blue than this