Skip to content

Simplify media insertion flow#2700

Merged
jd-alexander merged 22 commits intodevelopfrom
issue-946/simplify_image_insertion_flow
Apr 21, 2021
Merged

Simplify media insertion flow#2700
jd-alexander merged 22 commits intodevelopfrom
issue-946/simplify_image_insertion_flow

Conversation

@jd-alexander
Copy link
Copy Markdown
Contributor

@jd-alexander jd-alexander commented Oct 9, 2020 •
edited
Loading

Fixes #946
Gutenberg PR WordPress/gutenberg#29546

This change simplifies the media insertion flow by showing the media options sheet when you tap the Media block to add the Media placeholder to the canvas. Before you would have to add the placeholder and click for eg. Add Image for it to be shown.
To test:
WordPress/gutenberg#29546
PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@jd-alexander jd-alexander added the [Type] Enhancement Improves a current area of the editor label Oct 9, 2020
@jd-alexander jd-alexander requested a review from guarani October 9, 2020 02:13
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Oct 9, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

guarani
guarani approved these changes Oct 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding my approval here, since I already reviewed and approved WordPress/gutenberg#25031 (review).

@jd-alexander jd-alexander mentioned this pull request Mar 3, 2021
Closed
6 tasks
@jd-alexander jd-alexander requested a review from guarani March 3, 2021 00:08
@jd-alexander jd-alexander mentioned this pull request Mar 4, 2021
Merged
7 tasks
This was referenced Mar 4, 2021
Merged
Merged
guarani
guarani approved these changes Mar 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just approving this since the linked Gutenberg PRs are approved. I think this is missing an entry in the release notes though (and we're missing an entry in the react-native-editor package change log).

@jd-alexander
Copy link
Copy Markdown
Contributor Author

jd-alexander commented Mar 12, 2021

Just approving this since the linked Gutenberg PRs are approved. I think this is missing an entry in the release notes though (and we're missing an entry in the react-native-editor package change log).

Thanks. I was planning to put the release notes in and request a review from you. Can I just put them in and merge afterwards ?

@guarani
Copy link
Copy Markdown
Contributor

guarani commented Mar 12, 2021

Just approving this since the linked Gutenberg PRs are approved. I think this is missing an entry in the release notes though (and we're missing an entry in the react-native-editor package change log).

Thanks. I was planning to put the release notes in and request a review from you. Can I just put them in and merge afterwards ?

Yeah sure, I don't mind either way.

@jd-alexander
Copy link
Copy Markdown
Contributor Author

jd-alexander commented Mar 12, 2021 •
edited
Loading

Just approving this since the linked Gutenberg PRs are approved. I think this is missing an entry in the release notes though (and we're missing an entry in the react-native-editor package change log).

Thanks. I was planning to put the release notes in and request a review from you. Can I just put them in and merge afterwards ?

Yeah sure, I don't mind either way.

No problem. I will sync with trunk and get all these PRs merged in on Monday.

@jd-alexander jd-alexander added this to the 1.50.0 (17.1) milestone Mar 17, 2021
@jd-alexander jd-alexander removed this from the 1.50.0 (17.1) milestone Mar 30, 2021
@jd-alexander jd-alexander requested a review from fluiddot April 19, 2021 22:02
fluiddot
fluiddot reviewed Apr 20, 2021
View reviewed changes
@jd-alexander jd-alexander merged commit d30a912 into develop Apr 21, 2021
@jd-alexander jd-alexander deleted the issue-946/simplify_image_insertion_flow branch April 21, 2021 00:06
@cameronvoell cameronvoell added this to the 1.52.0 (17.3) milestone May 1, 2021
@cameronvoell cameronvoell mentioned this pull request May 1, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@fluiddot fluiddot fluiddot left review comments

@guarani guarani guarani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Milestone

1.52.0 (17.3)

Development

Successfully merging this pull request may close these issues.

Simplify media insertion flow

4 participants

@jd-alexander @guarani @fluiddot @cameronvoell