Skip to content

Update Preview handling for better Android support#2696

Merged
chipsnyder merged 5 commits intodevelopfrom
issue/2452-previewAndroid
Oct 8, 2020
Merged

Update Preview handling for better Android support#2696
chipsnyder merged 5 commits intodevelopfrom
issue/2452-previewAndroid

Conversation

@chipsnyder
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder commented Oct 7, 2020 •
edited by antonis
Loading

Fixes #2452
Related PR
gutenberg WordPress/gutenberg#25930

To test:

To disable or enable the development version of Modal Layout Picker
  • Open the app from the build that allows FeatureFlags such as a PR build or a local development build
    • By default, the modal layout picker will be disabled.
    • From the site page:
      • Click on your Gravatar.
      • Click on App Settings.
      • Click on Debug.
      • Toggle "Gutenberg Modal Layout Picker" to enable or disable the picker

On WPAndroid:

Download the Android app with the Preview functionality from wordpress-mobile/WordPress-Android#13022

With the metro server running

  1. Open the MLP either via the FAB icon > Site Page or by navigating to Pages and selecting the ➕
  2. Select a layout
  3. Select Preview
  4. Expect to see the loading indicator
  5. Expect to see the layout preview loaded successfully
  6. Validate that the loading indicator is dismissed

On WPiOS:

With the metro server running

  1. Enable MLP
  2. Open the MLP either via the FAB icon > Site Page or by navigating to Pages and selecting the ➕
  3. Select a layout
  4. Select Preview

Expect The Preview to load

Also, open existing posts/pages and create new posts/pages and expect those to load as well.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder added [Type] Bug Something isn't working [OS] Android labels Oct 7, 2020
@chipsnyder chipsnyder requested review from antonis and geriux October 7, 2020 22:50
@chipsnyder chipsnyder mentioned this pull request Oct 7, 2020
Merged
6 tasks
@antonis antonis mentioned this pull request Oct 8, 2020
Merged
3 tasks
antonis
antonis approved these changes Oct 8, 2020
View reviewed changes
Copy link
Copy Markdown

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with WordPress/gutenberg#25930 👍

@chipsnyder chipsnyder marked this pull request as ready for review October 8, 2020 13:42
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Oct 8, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@chipsnyder chipsnyder merged commit 7ac70a0 into develop Oct 8, 2020
@chipsnyder chipsnyder deleted the issue/2452-previewAndroid branch October 8, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geriux geriux Awaiting requested review from geriux

1 more reviewer

@antonis antonis antonis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[OS] Android [Type] Bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chipsnyder @antonis