Skip to content

[Modal Layout Picker] Adds Editor Mode for the "Preview" button functionality#2674

Merged
antonis merged 6 commits intodevelopfrom
issue/2452-Preview
Sep 30, 2020
Merged

[Modal Layout Picker] Adds Editor Mode for the "Preview" button functionality#2674
antonis merged 6 commits intodevelopfrom
issue/2452-Preview

Conversation

@antonis
Copy link
Copy Markdown

@antonis antonis commented Sep 28, 2020

Fixes: #2452

Related PRs:

Description

Adds editorMode initial property with values editor(default) and preview

How has this been tested?

This feature can be tested by using the build from wordpress-mobile/WordPress-Android#13022

Types of changes

New feature (non-breaking change which adds functionality)

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Sep 28, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonis antonis merged commit 4d2b4f6 into develop Sep 30, 2020
@antonis antonis deleted the issue/2452-Preview branch September 30, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants