Add CI Check for package-lock.json diffs#2664
Merged
Conversation
Instead of local package-lock.json
Text color doesn't work on CI machine
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Contributor
|
@etoledom Just reminding that we'll be cutting the 1.38 release branch later in the day Monday 9/28. Please try to get this merged by then or bump the milestone. Thanks much 🙇 |
Contributor
Author
ceyhun
approved these changes
Sep 28, 2020
Contributor
ceyhun
left a comment
There was a problem hiding this comment.
LGTM! Will trigger CI one last time.
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a CI check for changes on
package-lock.jsonafter runningnpm install.With this check we will ensure that our
package-lock.jsonis always updated and changes are committed.To test:
check-correctnessjobPR submission checklist: