Merged
Conversation
3 tasks
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
mchowning
approved these changes
Sep 23, 2020
Contributor
mchowning
left a comment
There was a problem hiding this comment.
Approved via WordPress/gutenberg#25488 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do NOT merge this PR - we plan to merge it together with PRs from gutenberg and WPAndroid.
I'm not sure what milestone I should target - I picked the one at the top.
Description
This PR updates
gutenbergsubmodule ref - it uses a commit from a forked repo since the changes hasn't been merged yet (https://github.com/malinajirka/gutenberg.git). Corresponding PR in gutenberg repo.Changes in the
gutenbergsubmodule:This change is required so we can update WPAndroid - draft PR.
How has this been tested?
I have tested the changes in WPAndroid - successful build should be enough.
Types of changes
Updates build setup for Android
Checklist: