Skip to content

Fix image block render in Xcode 12#2645

Merged
guarani merged 2 commits intodevelopfrom
rnmobile/fix-images-in-xcode12
Sep 28, 2020
Merged

Fix image block render in Xcode 12#2645
guarani merged 2 commits intodevelopfrom
rnmobile/fix-images-in-xcode12

Conversation

@guarani
Copy link
Copy Markdown
Contributor

@guarani guarani commented Sep 18, 2020

This PR fixes #25431 which is a bug that prevents Image blocks from rendering their images. This only affects builds made using Xcode 12.

To test: See WordPress/gutenberg#25470

⚠️ I opted not to include release notes because while this is a user facing bug fix, it only affects builds made using Xcode 12 and the App Store versions of WPiOS are still built using Xcode 11.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@guarani guarani requested a review from ceyhun September 18, 2020 22:01
@guarani guarani added the [Type] Bug Something isn't working label Sep 18, 2020
Copy link
Copy Markdown
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guarani guarani force-pushed the rnmobile/fix-images-in-xcode12 branch from db2f502 to 31add4f Compare September 28, 2020 21:15
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Sep 28, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@guarani guarani merged commit 962d33e into develop Sep 28, 2020
@guarani guarani deleted the rnmobile/fix-images-in-xcode12 branch September 28, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants