Skip to content

Buttons Block: Adds debounce in the add button action#2625

Merged
antonis merged 4 commits intodevelopfrom
issue/2238_AddButtonsDebounce
Sep 18, 2020
Merged

Buttons Block: Adds debounce in the add button action#2625
antonis merged 4 commits intodevelopfrom
issue/2238_AddButtonsDebounce

Conversation

@antonis
Copy link
Copy Markdown

@antonis antonis commented Sep 16, 2020

Gutenberg PR -> WordPress/gutenberg#25376

Fixes #2238

When user taps fast multiple times on side "+" icon to add multiple buttons the app does not fall in a loop (iOS) or freezes (Android).

This PR adds debounce in the add button action.

To test check the Gutenberg PR.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Sep 18, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@antonis antonis requested a review from lukewalczak September 18, 2020 09:05
@antonis antonis merged commit 4e80177 into develop Sep 18, 2020
@antonis antonis deleted the issue/2238_AddButtonsDebounce branch September 18, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants