Skip to content

Feature/unsupported block editor jetpack sso enabled#2542

Merged
etoledom merged 26 commits intodevelopfrom
feature/unsupported-block-editor-jetpack-sso-enabled
Sep 11, 2020
Merged

Feature/unsupported block editor jetpack sso enabled#2542
etoledom merged 26 commits intodevelopfrom
feature/unsupported-block-editor-jetpack-sso-enabled

Conversation

@marecar3
Copy link
Copy Markdown
Contributor

@marecar3 marecar3 commented Aug 11, 2020

Fixes part of #2471

Gutenberg PR: WordPress/gutenberg#24476

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@marecar3 marecar3 requested review from etoledom and guarani August 11, 2020 03:04
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Aug 11, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@marecar3 marecar3 requested a review from mchowning August 25, 2020 04:18
Copy link
Copy Markdown
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had an issue with self-hosted: WordPress/gutenberg#24476 (review)

@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Sep 9, 2020

I had an issue with self-hosted: WordPress/gutenberg#24476 (review)

This should be clarified already. Would you mind taking another 👀 ?
Nothing much have changed since your last PR, but we have resolved the reason of the failure of your tests.

@guarani guarani self-requested a review September 9, 2020 22:37
Copy link
Copy Markdown
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing Android here and iOS here I'd say this looks good to me 👍

@etoledom etoledom merged commit fa738f5 into develop Sep 11, 2020
@etoledom etoledom deleted the feature/unsupported-block-editor-jetpack-sso-enabled branch September 11, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants