Skip to content

Glue code to get content info metrics#2383

Merged
SergioEstevao merged 2 commits intoissue/content_infofrom
issue/content_info-hypest
Jun 16, 2020
Merged

Glue code to get content info metrics#2383
SergioEstevao merged 2 commits intoissue/content_infofrom
issue/content_info-hypest

Conversation

@hypest
Copy link
Copy Markdown
Contributor

@hypest hypest commented Jun 13, 2020 •
edited
Loading

Expands #2380 to include the Android side of the call to get content information.

To test:
Use the WPAndroid PR to test: wordpress-mobile/WordPress-Android#12191

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hypest hypest added this to the 1.31 milestone Jun 13, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jun 13, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@hypest hypest mentioned this pull request Jun 13, 2020
Merged
3 tasks
@hypest hypest changed the title Issue/content info hypest Glue code to get content info metrics Jun 13, 2020
@hypest hypest mentioned this pull request Jun 13, 2020
Merged
2 tasks
@hypest hypest requested a review from mchowning June 13, 2020 01:37
@SergioEstevao
Copy link
Copy Markdown
Contributor

SergioEstevao commented Jun 15, 2020

@hypest any possibility to add a way to check the information directly in the demo app?

@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented Jun 15, 2020

any possibility to add a way to check the information directly in the demo app?

We could add a menu item on the RN Debug menu, similar to the "Show html" we have added in the past, but that's not a scalable solution. We needed the "Show html" one for the UI tests so we added it, but this one is probably not as important to have.

Unlike the iOS demo app, the Android demo app doesn't have chrome/toolbar around the editor.

@SergioEstevao SergioEstevao self-requested a review June 15, 2020 15:23
SergioEstevao
SergioEstevao approved these changes Jun 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in terms of functionality in the main apps and it's working great!
I will leave it to @mchowning to check the code.

@SergioEstevao SergioEstevao merged commit 3f55845 into issue/content_info Jun 16, 2020
@SergioEstevao SergioEstevao deleted the issue/content_info-hypest branch June 16, 2020 09:15
@mchowning mchowning mentioned this pull request Jun 23, 2020
Closed
5 tasks
@SergioEstevao SergioEstevao mentioned this pull request Jun 24, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@mchowning mchowning Awaiting requested review from mchowning

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.31

Development

Successfully merging this pull request may close these issues.

2 participants

@hypest @SergioEstevao