Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
pinarol
left a comment
There was a problem hiding this comment.
LGTM, see for test effort: WordPress/gutenberg#23110 (comment)
|
Let's not forget to add release notes, though. |
|
Hey there 👋 @iamthomasbishop ! Whenever you have a chance, could you please test this feature and give us your feedback? Here you'll find the builds:
More info and screenshots here. Thank you so much! |
3a46079 to
9563614
Compare
|
@geriux This is looking pretty solid already — nice work! After testing out pretty extensively, I've got a bunch of feedback which I'll try to keep succinct 🙂 I'm sure we'll need another round of review, but this should cover the big picture things. Overfow menu
Native select/copy/paste
Notice component
Unrelated
|
Actually "Cut block" is implemented behind the scenes on web, but it is connected with Cmd+X. It is just not in the menu but the functionality is there. You can see this small notice on web when you do cmd+x: And as you know you can drag&drop blocks inside/outside a nested block by pressing down the up/down buttons on web. But we don't have a way to move a block inside/outside a nested block. In this sense Cut functionality is quite useful imo, and it is a quick win for us since we are already implementing Copy/Paste/Duplicate, wdyt? |
|
👋 @geriux ! We're close to merging the monorepo changes 🎉 , and we will be cutting the release branches as soon as the monorepo changes are merged to gutenberg-mobile. As a result, we may be cutting the 1.31 release branches earlier than normal. Because every merge further delays the monorepo work (ends up requiring conflicts to be fixed and other work due to the monorepo feature branch and the squash policy in gutenberg), we want to cut the release branch with no further changes. For that reason, I'll bump this milestone to 1.32. Of course, if this has to make the 1.31 release, go ahead and move it back to the 1.31 milestone, and let me know. 🙇 |
Sounds good! Thanks for letting me know Matt 🙌 |
Hey, @iamthomasbishop 👋 I've added the library to test how it'd work, here's a light mode example and a dark mode one. Is that what you had in mind? If it is I can prepare a build for you to test. Also, to double check, this is only for iOS right? Thanks! |
|
@geriux That looks great, glad to see you were easily able to implement it! I'm not sure what values you're using, but it feels a little thin esp on light mode. I'm looking over the library readme and it looks like we have access to various |
@pinarol Fair points you made above, let's keep |
I was using
What do you think of those? If you want other examples let me know =) Thanks! |
|
@geriux I pulled these screenshots into Figma to compare against the system material equivalents I have.
Another thing I think I'd like to do is to remove the border-bottom from both iOS and Android — I thought it might be necessary for separation, but it doesn't quite look right esp on iOS. I'll update the component on the Figma + design docs side. |
9563614 to
e43ccf8
Compare
|
That looks great, let's roll with it. Nice work @geriux ! Side note: I think this will only look better when the Navigation Bars on the apps are all (eventually) changed to use the translucent materials. 😄 |
e43ccf8 to
6cb1028
Compare








Fixes #2326
Gutenberg PR-> WordPress/gutenberg#23110WordPress iOS PR-> wordpress-mobile/WordPress-iOS#14392WordPress Android PR-> wordpress-mobile/WordPress-Android#12187This PR adds the functionality to copy, cut, paste, and duplicate blocks. This would be very useful to be able to move blocks from inner blocks or to group blocks like Group or Columns.
To test check
GutenbergPR description.PR submission checklist:
RELEASE-NOTES.txtif necessary.