Issue/426 fix enter on captions#2352
Merged
SergioEstevao merged 10 commits intodevelopfrom Jun 8, 2020
Merged
Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
6 tasks
Contributor
|
I'm seeing an issue with this on Android only where pressing Enter both creates a new paragraph block and adds a |
mchowning
approved these changes
Jun 8, 2020
Contributor
mchowning
left a comment
There was a problem hiding this comment.
Tested via WordPress/gutenberg#22928 and looks good! 👍
# Conflicts: # gutenberg
Contributor
|
Is this also fixing #1651? |
Contributor
👍 Closed the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #426
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.