Fix link insertion at start of lists.#2323
Merged
SergioEstevao merged 3 commits intodevelopfrom May 27, 2020
Merged
Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
6 tasks
Contributor
|
Just tested the PR. It seems that the cursor does move to the end when adding a new link but it doesn't work when converting existing text. Thus the bug described in #2319 is still reproducible. |
guarani
approved these changes
May 27, 2020
Contributor
guarani
left a comment
There was a problem hiding this comment.
Just tested the PR. It seems that the cursor does move to the end when adding a new link but it doesn't work when converting existing text. Thus the bug described in #2319 is still reproducible.
@SergioEstevao told me this ended up being a non-issue.
Tested scenarios on iOS & Android working as expected
- ✅ Add link to existing text
- ✅ Add link and text to the end of exiting text
- ✅ Multi-line links
- ✅ Deleting and editing links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2319
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.