Merged
Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
guarani
approved these changes
May 26, 2020
Contributor
There was a problem hiding this comment.
Everything is working as expected in this PR – although I uncovered a preexisting bug (#2319) where links can disappear from lists, paragraphs and quotes when Enter is pressed.
- ✅ Create a list block
- ✅ Write some test in an item
- ✅ Add a link to the full text on the line
- ✅ Check that the underline does not expand to the full line.
- Tap Enter (
⚠️ see preexisting bug mentioned earlier in this comment) - ✅ Check that the underline does not expand to the full line.
- ✅ Test the same using the Paragraph block and the Quote block
Selection link bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1218
This update of Aztec fixes another instance of the underlines going the full width of a line.
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.