Skip to content

Fix Missing Placeholder on Quote Blocks#2307

Merged
cameronvoell merged 11 commits intodevelopfrom
fix/1970-missing-quote-placeholder
Aug 31, 2020
Merged

Fix Missing Placeholder on Quote Blocks#2307
cameronvoell merged 11 commits intodevelopfrom
fix/1970-missing-quote-placeholder

Conversation

@cameronvoell
Copy link
Copy Markdown
Contributor

@cameronvoell cameronvoell commented May 23, 2020 •
edited
Loading

Fixes #1970

Description

This change is for fixing missing placeholder text on Quote and Pullquote blocks on Android.
See Gutenberg PR for more details.

Gutenberg PR: WordPress/gutenberg#22561

To test:

  1. Add Quote and Pullquote blocks, verify that the "Enter Quote" placeholder text is visible.
  2. Try adding multiline quotes and merging other blocks into a quote block, make sure no text is lost.
  3. Smoke test other rich text based blocks to ensure there is no unintended behavior.

Screenshot

Screen Shot 2020-05-22 at 6 20 29 PM

submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented May 23, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@cameronvoell cameronvoell self-assigned this May 23, 2020
@cameronvoell cameronvoell mentioned this pull request May 23, 2020
Merged
6 tasks
@cameronvoell cameronvoell force-pushed the fix/1970-missing-quote-placeholder branch from cb70c18 to ea6d03f Compare May 23, 2020 01:44
@cameronvoell cameronvoell marked this pull request as ready for review May 23, 2020 02:44
@cameronvoell cameronvoell mentioned this pull request May 23, 2020
Closed
@hypest hypest requested review from SergioEstevao and removed request for hypest May 25, 2020 14:08
@mchowning
Copy link
Copy Markdown
Contributor

mchowning commented Jul 14, 2020

👋 @cameronvoell ! I noticed that the gutenberg-side PR for this is marked as a draft. Could this one be a draft as well, or perhaps these should be closed?

@hypest hypest deleted the fix/1970-missing-quote-placeholder branch August 13, 2020 09:45
@hypest
Copy link
Copy Markdown
Contributor

hypest commented Aug 13, 2020

👋 @cameronvoell , noticed you closed this PR recently. If that was intentional, can you add a comment on the reasoning so to close the loop? Thanks!

@cameronvoell cameronvoell restored the fix/1970-missing-quote-placeholder branch August 21, 2020 22:54
@cameronvoell cameronvoell reopened this Aug 21, 2020
@cameronvoell cameronvoell marked this pull request as draft August 21, 2020 22:56
@cameronvoell cameronvoell marked this pull request as ready for review August 28, 2020 05:01
mchowning
mchowning approved these changes Aug 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#22561 (review)!

This was referenced Aug 31, 2020
Merged
Merged
@cameronvoell cameronvoell merged commit da234f0 into develop Aug 31, 2020
@cameronvoell cameronvoell deleted the fix/1970-missing-quote-placeholder branch August 31, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ceyhun ceyhun Awaiting requested review from ceyhun

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

1 more reviewer

@mchowning mchowning mchowning approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cameronvoell cameronvoell

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Quote block placeholder is not visible

3 participants

@cameronvoell @mchowning @hypest