Skip to content

Enable using the JitPack mode of building from a parent project#2231

Merged
hypest merged 11 commits intomasterfrom
try/no-jitpack-for-wpandroid
May 8, 2020
Merged

Enable using the JitPack mode of building from a parent project#2231
hypest merged 11 commits intomasterfrom
try/no-jitpack-for-wpandroid

Conversation

@hypest
Copy link
Copy Markdown
Contributor

@hypest hypest commented May 6, 2020 •
edited
Loading

Addresses #2182

We currently experience high failure rate on JitPack building the gutenberg-mobile artifact for WPAndroid, so this PR tries to enable building the artifact and the JS bundle locally, by reusing the gradle-powered Node/RN build.

This mode is then used by WPAndroid. Related PR: wordpress-mobile/WordPress-Android#11833

To test:

  1. CI should be green
  2. Integration in the WPAndroid PR should be OK and green too. Nothing special to test out on this side.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hypest hypest mentioned this pull request May 6, 2020
Merged
3 tasks
@mchowning
Copy link
Copy Markdown
Contributor

mchowning commented May 7, 2020

Do we still want jitpack code in react-native-gutenberg-bridge?

@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented May 8, 2020

Do we still want jitpack code in react-native-gutenberg-bridge?

Actually, yes. This PR only removes the gutenberg-mobile bridge library building on Jitpack, but we still have the npm package forks be built on JitPack. Those repos are smaller and don't seem to pose an issue yet.

@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented May 8, 2020 •
edited
Loading

The WPAndroid PR will target a release so, this PR shall also target master. Will change it to that. Since this PR is introducing integration changes but no functional changes, I'm not planning to bump the library version nor new bundles.

@hypest hypest force-pushed the try/no-jitpack-for-wpandroid branch from c8bc57a to 846dcc6 Compare May 8, 2020 01:03
@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented May 8, 2020

cc @geriux since you're currently wrangling a hotfix release and this PR now targets master. Most probably, the hotfix will need to update after this lands on time.

@hypest hypest requested a review from marecar3 May 8, 2020 01:41
@hypest hypest marked this pull request as ready for review May 8, 2020 01:41
@geriux
Copy link
Copy Markdown
Contributor

geriux commented May 8, 2020 •
edited
Loading

cc @geriux since you're currently wrangling a hotfix release and this PR now targets master. Most probably, the hotfix will need to update after this lands on time.

Cool! thanks for letting me know 👍

@hypest hypest changed the base branch from develop to master May 8, 2020 07:43
@hypest hypest requested a review from SergioEstevao May 8, 2020 10:30
SergioEstevao
SergioEstevao approved these changes May 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building and running the demo app!
I did some smoke test on the demo app and it all looks ok.

@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented May 8, 2020

There's only one CI job pending on the WPAndroid PR (on this commit), which seems to be waiting for Firebase to queue the tests run, for more than 25mins now. I will start the merge domino since everything else is green at this point. Besides, that job will get re-triggered anyway.

@hypest hypest merged commit 9e0143f into master May 8, 2020
@hypest hypest deleted the try/no-jitpack-for-wpandroid branch May 8, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@marecar3 marecar3 Awaiting requested review from marecar3

Assignees

No one assigned

Labels

App Integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hypest @mchowning @geriux @SergioEstevao