Issue/update aztec ios to 1.19.0#2226
Conversation
etoledom
left a comment
There was a problem hiding this comment.
Thank you @SergioEstevao for this PR!
I found two details:
Running pod install locally gives this diff:
- React
- - react-native-video (5.0.2):
+ - react-native-video (5.0.1):
- React
- - react-native-video/Video (= 5.0.2)
- - react-native-video/Video (5.0.2):
+ - react-native-video/Video (= 5.0.1)
+ - react-native-video/Video (5.0.1):
I tried removing the Pods folder to be sure, and the diff appeared again. I wasn't sure since it's a version downgrade.
The other is something I didn't noticed in the Aztec PR, and I'm not sure if it's expected or not:
When I try to modify text before the subscript (or superscript) that text will be add as part of the subscript.
That is expected it should work the same way as bold, italic, strikethrough. |
|
@etoledom I don't see the issue with the podfile in my machine, can you try to run yarn install before the pod install? the video library was updated recently so you may have missed that update. |
etoledom
left a comment
There was a problem hiding this comment.
can you try to run yarn install before the pod install?
You are completely right! 🙏
Let's merge!
Updates Aztec to version 1.19.0
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.