Skip to content

Update GB reference.#2173

Merged
SergioEstevao merged 4 commits intodevelopfrom
issue/revert_video_player_inline_on_iOS
Apr 22, 2020
Merged

Update GB reference.#2173
SergioEstevao merged 4 commits intodevelopfrom
issue/revert_video_player_inline_on_iOS

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

Revert the video player refactor to allow playing iOS videos inline.

Related GB PR: WordPress/gutenberg#21770

To test:

  • Start the demo app
  • Make sure the title is completely visible on the visual mode and HTML mode.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So bad that this was the reason for the Post Title layout bug.
It looks good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants