Skip to content

Updating Aztec Android ref to Release v1.3.40#2170

Merged
cameronvoell merged 1 commit intodevelopfrom
update/aztec-android-update-v1.3.40
Apr 24, 2020
Merged

Updating Aztec Android ref to Release v1.3.40#2170
cameronvoell merged 1 commit intodevelopfrom
update/aztec-android-update-v1.3.40

Conversation

@cameronvoell
Copy link
Copy Markdown
Contributor

@cameronvoell cameronvoell commented Apr 20, 2020

Background

Aztec Android was updated here for new AztecToolbar customization options.

This PR is for updating Gutenberg-mobile to be on the latest Aztec Android and in sync with the WordPress Android app Aztec version.

Related PR

See WordPress Android update of Aztec Version to v1.3.40 here: wordpress-mobile/WordPress-Android#11594

Testing

You can use the following branch to test this Aztec update in WPAndroid: woo/aztec-design-changes-TEST-gb-update.

  1. Test blocks that use Aztec/RichText Component (Paragraph, List, Verse, etc)
  2. Test scrolling up and down on longer articles.
  3. Test within WordPress Android app.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@cameronvoell
Copy link
Copy Markdown
Contributor Author

cameronvoell commented Apr 21, 2020

In addition to the broad tests in the description I went through the following "writing flow sanity checks"

@cameronvoell cameronvoell requested a review from mkevins April 24, 2020 02:32
Copy link
Copy Markdown
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested via the steps in the sanity tests, and found no regressions. Looks good! Before merging, just want to check if there was a "superseding" PR on the way, since Aztec has a later version now (v1.3.41). cc: @marecar3 Marko 👋 😄 is there any plan to bump gutenberg-mobile and WordPress-Android references to Aztec for this release: https://github.com/wordpress-mobile/AztecEditor-Android/releases/tag/v1.3.41 ?

@cameronvoell , feel free to merge this one either way, just wanted to save effort if we'd be bumping to the next version in another PR anyway.

@cameronvoell cameronvoell merged commit 9abd4ac into develop Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants