Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@Stojdza There's a lot of repetition between the canary and full jobs in the CircleCI config. What do you think of using a more DRY approach with a single device test job per platform, using a parameter to determine whether it's a full run or just canaries?

That way, for example, we could have a single android-device-checks job in the config and just change the parameter in the workflows, instead of android-device-checks and android-device-checks-canary where most of the steps are the same.

(Sorry for the delay looking at this; I didn't realize until recently that it was still open and waiting for review.)

Also, do you know why ci/circleci: Test Android on Device and ci/circleci: Test iOS on Device still show up as expected checks on this PR? My guess is because they're marked as required in our branch protection rules, but I wanted to point that out in case there's something else involved. (We'll also want to make sure to update the branch protection rules to remove that required check and switch to the Canaries as the required check, I guess?)

Thanks for looking into this @rachelmcr. It's never too late 😄

What do you think of using a more DRY approach with a single device test job per platform, using a parameter to determine whether it's a full run or just canaries?

I agree! I know back then it was easier just to copy and paste, and test jobs. Later I forgot to solve it properly. I can take a look at it later this week if that works?

Also, do you know why ci/circleci: Test Android on Device and ci/circleci: Test iOS on Device still show up as expected checks on this PR?

Yes. If you take a look here, under Require status checks to pass before merging, you'll notice that Test Android on Device - Canaries and Test iOS on Device - Canaries are not checked/mandatory, and Test Android on Device and Test iOS on Device are mandatory. While I tested these changes, @hypest changed these settings for me (since I didn't have permissions) and it looked as expected. That's why I put this notice in the description:

@hypest once this PR is approved and ready to merge, we should change required jobs for develop branch - canaries should be marked as required and Test Android/iOS on Device should be unchecked.

I can take a look at it later this week if that works?

Works for me, thank you! Let me know if you can't fit it in with the other things you're working on now and I can take a look.

That's why I put this notice in the description

Ah yeah, thanks for confirming! I saw that the first time I read the description but overlooked it when I reread it for this review. :)

@rachelmcr I added agreed changes. Let me know what do you think. Tests are running as expected - only three tests as canaries and full suite upon approval.

@maxme @hypest we should sync on this:

once this PR is approved and ready to merge, we should change required jobs for develop branch - canaries should be marked as required and Test Android/iOS on Device should be unchecked.

Once you're ready to change required jobs we can merge this PR.

Thanks for the ping @Stojdza, I made the change and now PRs against develop will only require the Canaries, not the full device testsuite.

Also, can you update the PR description to mention that the full suite will indeed run anyway, based on a schedule? Thanks!

Thanks @hypest! I updated PR description.