Adjust RangeControl to add the stepper control and allow type selection#2125
Merged
chipsnyder merged 6 commits intodevelopfrom Apr 15, 2020
Merged
Adjust RangeControl to add the stepper control and allow type selection#2125chipsnyder merged 6 commits intodevelopfrom
chipsnyder merged 6 commits intodevelopfrom
Conversation
6 tasks
|
You can trigger optional full suite of UI tests for these changes by visiting CircleCI here. |
Contributor
|
I am changing the milestone of this PR as 1.27 because the 1.26 release branch will be cut quite soon. Let me know if you instead wanted to include this to 1.26. |
geriux
approved these changes
Apr 14, 2020
Contributor
geriux
left a comment
There was a problem hiding this comment.
LGTM! Approved via WordPress/gutenberg#21465 (review)
This was referenced Apr 27, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1992
gutenbergWordPress/gutenberg#21465Description
This PR refactors the RangeControl component to allow the optional parameter
typeto allow selection between the Stepper control or a slider control on Mobile.Since the range control is being used in multiple places right now as a slider control, I made the slider the default option.
This PR also updates the gallery component to pass in
type=stepperto test the other use flow. The gallery component was also the only place where I could find references to the stepper control.How has this been tested?
Stepper:
Details
Slider:
Details
Open a control using the RangeControl. Examples:
Expect to see the slider control
PR submission checklist:
RELEASE-NOTES.txtif necessary.