[iOS] Use react native 0.62 hook for dark mode#2120
Merged
marecar3 merged 6 commits intoupdate-rn-0-62from Apr 13, 2020
Merged
Conversation
6 tasks
…_ios # Conflicts: # gutenberg # package.json
…ub.com/wordpress-mobile/gutenberg-mobile into try/use_rn_0.62_hook_for_dark_mode_ios
etoledom
approved these changes
Apr 13, 2020
Contributor
etoledom
left a comment
There was a problem hiding this comment.
Approved via WordPress/gutenberg#21455 (review)
🎉
Contributor
Author
Thanks! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
With React Native 0.62 we got built-in dark mode feature: https://reactnative.dev/blog/2020/03/26/version-0.62#new-dark-mode-features
which allows us to remove
react-native-dark-modelibrary from the project.Fellow Gutenberg PR: WordPress/gutenberg#21455
To test:
The dark mode should work as expected both in the Demo app and the WPiOS app.
PR submission checklist:
RELEASE-NOTES.txtif necessary.