Skip to content

Create a stable version of @wordpress/interface components for mobile#2113

Merged
Tug merged 2 commits intodevelopfrom
fix/target-gutenberg-master
Apr 6, 2020
Merged

Create a stable version of @wordpress/interface components for mobile#2113
Tug merged 2 commits intodevelopfrom
fix/target-gutenberg-master

Conversation

@Tug
Copy link
Copy Markdown
Contributor

@Tug Tug commented Apr 6, 2020

This PR fixes recent breakage in gutenberg, allowing us to target master again.

Gutenberg PR: WordPress/gutenberg#21425

To test: Run a smoke test on the app. Especially: it should not crash on load

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Tug Tug added the Web breakage Caused by incompatible changes on Gutenberg web label Apr 6, 2020
@Tug Tug requested a review from SergioEstevao April 6, 2020 11:56
@Tug Tug self-assigned this Apr 6, 2020
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well on iOS and Android!

@Tug Tug merged commit 7898f98 into develop Apr 6, 2020
@Tug Tug deleted the fix/target-gutenberg-master branch April 6, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Web breakage Caused by incompatible changes on Gutenberg web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants