Conversation
6 tasks
Contributor
Author
|
Hey @mkevins @chipsnyder 👋 I've added you both to review and test this PR. Since the issue is for Android, could we split the testing in different APIs? I was thinking:
This way we double check all is working correctly. Thank you! |
chipsnyder
approved these changes
Apr 3, 2020
Contributor
chipsnyder
left a comment
There was a problem hiding this comment.
Approved with WordPress/gutenberg#21373 (review) Just pending Matt's review
mkevins
approved these changes
Apr 8, 2020
Contributor
mkevins
left a comment
There was a problem hiding this comment.
Approved via WordPress/gutenberg#21373 (review). LGTM!
added 2 commits
April 8, 2020 09:04
# Conflicts: # gutenberg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2093
Gutenberg PR-> WordPress/gutenberg#21373To test check the Gutenberg PR description
PR submission checklist:
RELEASE-NOTES.txtif necessary.