Skip to content

Support for the nextpage block#209

Merged
pinarol merged 9 commits intomasterfrom
feature/support-nextpage-block
Oct 30, 2018
Merged

Support for the nextpage block#209
pinarol merged 9 commits intomasterfrom
feature/support-nextpage-block

Conversation

@pinarol
Copy link
Copy Markdown
Contributor

@pinarol pinarol commented Oct 29, 2018

Add support for nextpage block. Most of the changes reside in this PR.

How has this been tested?

  • Make sure the (web) GB build and webapp work normally
  • Make sure the GB mobile app works normally and nextpage block is available for adding.
  • Make sure the GB mobile demo page has a next page block added initially

@pinarol pinarol requested a review from hypest October 29, 2018 15:08
@hypest hypest mentioned this pull request Oct 29, 2018
Merged
@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Oct 29, 2018 •
edited
Loading

Not sure if this is already figured out, but it looks like the travis errors are not related to this PR.
I followed these steps:

  • Checkout gutenberg-mobile master
    • Tests pass ✅
  • cd gutenberg
  • git checkout master (update Gutenberg reference to master)
    • Test fail with this same error ❌

We will probably need to update the gutenberg reference in our master and solve these tests issue there first.

That or start the gutenberg side of this PR from the hash we already know that is working for us (08897864660d68efb226c19b685699992598b791 at the moment of writing this)

cc @hypest

@hypest
Copy link
Copy Markdown
Contributor

hypest commented Oct 29, 2018

I tried the PR locally and can confirm that the tests get fixed if we create a new symlink, for the notices package. The change seems rather small so, I'd suggest we do it in this PR instead of a new one. WDYT @pinarol ?

@pinarol
Copy link
Copy Markdown
Contributor Author

pinarol commented Oct 30, 2018

thanks @etoledom for your suggestion, since the fix is very simple I just did it and got it out of our way as @hypest suggested :)

@pinarol pinarol mentioned this pull request Oct 30, 2018
Merged
5 tasks
hypest
hypest reviewed Oct 30, 2018
View reviewed changes
@pinarol pinarol requested a review from etoledom October 30, 2018 16:22
etoledom
etoledom approved these changes Oct 30, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are passing locally ✅
Builds and run flawlessly ✅
And the new block behaves as expected ✅

Everything tested in both iOS and Android (including tests).

I'd say it's good to go! :shipit:

@pinarol pinarol merged commit ca9b442 into master Oct 30, 2018
@hypest hypest deleted the feature/support-nextpage-block branch October 30, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hypest hypest hypest left review comments

@etoledom etoledom etoledom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pinarol @etoledom @hypest