Skip to content

Release 1.25.0 -> Master#2087

Merged
SergioEstevao merged 166 commits intomasterfrom
release/1.25.0
Apr 3, 2020
Merged

Release 1.25.0 -> Master#2087
SergioEstevao merged 166 commits intomasterfrom
release/1.25.0

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Mar 31, 2020 •
edited
Loading

Release for Gutenberg Mobile v1.25.0

Related PRs

Extra PRs that Landed After the Release Was Cut

Changes

  • Align controls are now "collapsed" in the toolbar menu. This applies to Paragraph, Heading, Image, Media-Text blocks
  • Added Cover block
  • [iOS] Added align options to the Heading block
  • [iOS] Fix bug where links at the end of a paragraph block were missing the underline on the last character.

Test plan

  • Use the main WP apps to test the changes above. See WPAndroid and WPiOS PRs if there are specific tests to run.
  • Smoke test the main WP apps for general writing flow.

PR Submission Checklist

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

pinarol and others added 30 commits March 4, 2020 09:10
@pinarol
Speed up execution
9db08e4
@ceyhun
Try running iOS e2e tests without launch argument
bd2e9e8
@ceyhun
Pass launch argument from Appium
e46695f
@ceyhun
Change default clear parameter for typeString on iOS to not be true
71c0ecd
@ceyhun
Remove default clear parameter for sendTextToParagraphBlock
8e17f72
@SergioEstevao
Update GB reference
f262d26 
Add emotion library to project to support styled Text component.
Update Gutenberg ref
6ae50c4
@SergioEstevao
Update GB reference.
c7e5ce3
@SergioEstevao
Update GB reference.
025c097
@SergioEstevao
Update to Aztec version with fix for align in headers.
72a52c9
@cameronvoell
Notify ReactManager that activity is destroyed
1c6be9f
@cameronvoell
Added bridge method notifying RN of closed modal
64a46aa
@ceyhun
Merge branch 'develop' into try/speed-up-uitests
36977f3
@ceyhun
Merge branch 'develop' into try/speed-up-uitests
0ef6dd5
@cameronvoell
No longer add notifyModalClosed listener on iOS
2ce4100
@cameronvoell
Updating gutenberg ref
b00c4e4
@koke
Update Gutenberg
0cfbfa9
@koke
Update Gutenberg
a6bc6f2
@koke
Merge branch 'develop' into spt-design-fixes
b8e850a
@hypest
Update Gutenberg ref to use video-alt2 icon
75f9940
@hypest
Add a release note for the take-a-video media option
f579ec6
@koke
Update Gutenberg
8e8f461
@koke
Merge branch 'develop' into spt-design-fixes
dd963d6
@koke
Merge pull request #2020 from wordpress-mobile/spt-design-fixes
4a41901 
Update page template picker after design review
@ceyhun
Merge pull request #1976 from wordpress-mobile/try/speed-up-uitests
df53d3d 
Speed up e2e tests execution
@hypest
Update Gutenberg ref
1d152c1
Update Gutenberg ref
4f49ac8
@hypest
Update Gutenberg ref
e7cf902
Update Gutenberg ref
503a5e8
Update Gutenberg ref
f91412a
etoledom
etoledom reviewed Apr 1, 2020
View reviewed changes
marecar3 and others added 4 commits April 1, 2020 10:49
@dratwas
Copy link
Copy Markdown
Contributor

dratwas commented Apr 1, 2020 •
edited
Loading

Android:

Group

  • Group - AppenderButton is rendered - steps
  • Group - Deep nesting is possible (iOS only) - steps
  • Group - Check if Group placeholder is visible for the unselected state - steps
  • Group - Check if Group placeholder is render in nested structure - steps
  • Group - Nested block have proper border styling - steps
  • Group - Nested block have proper margins values - steps
  • Group - Nested selection cause applying dimmed style on the rest of blocks - steps - This feature is removed
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - steps - With one exception - we turned off the floating toolbar for root level blocks that are not inner blocks.
  • Group - Navigation up button works as expected - steps
  • Group - Navigation down works according to parent-first approach - steps
  • Group - Cross navigation between blocks works as expected - steps
  • Group - Ungroup button works as expected - steps
  • Group - Check if in DarkMode all components gets proper colors (iOS) - steps
  • Group - Check if nested Placeholder block can be replaced - steps

Spacer

  • Spacer block - Spacer is rendered without crash - steps
  • Spacer block - Settings: Control spacer height using the slider - steps
  • Spacer block - Settings: Control spacer height using the text input - steps
  • Spacer block - Settings: Available height range is correct - steps
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - steps
  • Spacer block - Spacer in horizontal layout works as expected - steps

iOS

DarkMode

  • Gallery block - Dark mode - steps
  • Shortcode block - Dark mode - steps
  • Media Text block - Dark mode - steps
  • Spacer block - Dark mode - steps
  • Button block - Dark mode - steps
  • Group - Dark mode - steps

@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Apr 1, 2020 •
edited
Loading

WPiOS

  • Button block - Render custom text color - steps

  • Button block - Render custom background color - steps

  • Button block - Render gradient background color - steps

  • Button block - Check if selection / caret color matches font color - steps

  • Button block - Edit text styles - steps

  • Button block - Fallback to default colors in case theme colors are used - steps

  • Button block - New Button is created with the gray color - steps

  • Button block - Settings: Change Button border radius - steps

  • Button block - The newly created button has set background color to the theme-default color in preview - steps

  • Button block - Tapping delete key removes block when Button is empty - steps

  • Button block - Settings: Open in new tab - steps

  • Button block - Settings: Link rel - steps

  • Button block - Settings: Link URL - steps

  • Button block - Settings: Remove link - steps

  • Button block - Settings: Synchronize with button options - steps

  • Button block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - steps

  • Button block - Toolbar link button is active when Button has link - steps

  • Button block - Button max width is calculated OK inside inner blocks(iOS only) - steps

  • Cover - Add Video Background from WordPress Media library - steps

  • Cover - Replace media - steps

  • Cover - Gradient background is rendered properly - steps

  • Cover - Gradient overlay is rendered properly - steps

WPAndroid

  • Gallery block - Close/Re-open post with an ongoing image upload - steps
  • Gallery block - Close post with an ongoing image upload - steps
  • Gallery block - Insert image from device (failing) - steps
  • Gallery block - Insert image from device (cancel) - steps
  • Gallery block - Add Gallery Caption - steps
  • Gallery block - Add Gallery Image Caption - steps
  • Gallery block - Try adding same images from WP Media library and moving the images around - steps
  • Gallery block - Settings: Link to - steps
  • Gallery block - Settings: Column number - steps
  • Gallery block - Settings: Crop images - steps

etoledom
etoledom reviewed Apr 1, 2020
View reviewed changes
@pinarol pinarol mentioned this pull request Apr 1, 2020
Closed
@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Apr 1, 2020

Tests on WPiOS: ✅
wordpress-mobile/WordPress-iOS#13779 (comment)
wordpress-mobile/WordPress-iOS#13779 (comment)

@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Apr 1, 2020

Tests on WPAndroid: ✅
Not all writing flow tests had passed, but none of failures are new for this release.
wordpress-mobile/WordPress-Android#11572 (comment)
wordpress-mobile/WordPress-Android#11572 (comment)

@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Apr 2, 2020

I realized @mkevins 's tests are posted to WPiOS PR, just linking here to be able to find more easily.

@SergioEstevao SergioEstevao requested a review from hypest April 3, 2020 17:46
@SergioEstevao SergioEstevao merged commit e75a227 into master Apr 3, 2020
@hypest hypest deleted the release/1.25.0 branch April 3, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinarol pinarol pinarol left review comments

@hypest hypest Awaiting requested review from hypest

+1 more reviewer

@etoledom etoledom etoledom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SergioEstevao SergioEstevao

Labels

release-process

Projects

None yet

Milestone

1.25

Development

Successfully merging this pull request may close these issues.