Skip to content

Update Aztec-Android for alignment handling#2006

Merged
mchowning merged 1 commit intodevelopfrom
update_aztec_for_alignment
Apr 24, 2020
Merged

Update Aztec-Android for alignment handling#2006
mchowning merged 1 commit intodevelopfrom
update_aztec_for_alignment

Conversation

@mchowning
Copy link
Copy Markdown
Contributor

@mchowning mchowning commented Mar 12, 2020 •
edited
Loading

Description

Enables alignment on Android for non <p>-based blocks. In particular,

  1. Enables alignment for Heading blocks on Android (was already working on iOS);
  2. Applies center alignment for the Pullquote block on Android (was already working on iOS) Pullquote block #1854; and
  3. Enables alignment for the Verse block (the option was there before, but it didn't work) Enable alignment toolbar for verse block #2037;
  4. Enables alignment for the quote block on both platforms (alignment button was present, and it would update the HTML, but visually the block did not display the selected alignment) Quote Block display does not respect alignment #2161

⚠️ Once the AztecEditor-Android PR is merged, the aztecVersion in this PR must be updated before this is merged.

Related PRs

wordpress-mobile/AztecEditor-Android#899
WordPress/gutenberg#21803
wordpress-mobile/WordPress-Android#11752

Testing

These tests should all be performed on both iOS and Android.

Heading, Verse, and Quote Blocks

[Heading, Verse, Quote].forEach { block ->

  1. Select a ^block^
  2. Change the alignment for the block
  3. Observe the text visually updates to reflect the new alignment
  4. Verify that the HTML is updated with the new alignment

}

Pullquote Block

  1. Verify that the text in the Pullquote block has center alignment

Regressions

Verify that:

  • Alignment still works on Paragraph blocks
  • Image and video captions are still centrally aligned

PR submission checklist

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@mchowning mchowning added this to the 1.24 milestone Mar 12, 2020
@mchowning mchowning self-assigned this Mar 12, 2020
@mchowning mchowning mentioned this pull request Mar 12, 2020
Merged
1 task
@marecar3
Copy link
Copy Markdown
Contributor

marecar3 commented Mar 16, 2020

We're freezing 1.24.0 today. If you think it is ready and if you'd like to ship it with 1.24.0please merge it into develop branch. Otherwise, we can bump it to 1.25.0. @mchowning

@mchowning mchowning modified the milestones: 1.24, 1.25 Mar 17, 2020
@mchowning mchowning mentioned this pull request Mar 25, 2020
Closed
@SergioEstevao SergioEstevao self-assigned this Mar 25, 2020
@SergioEstevao
Copy link
Copy Markdown
Contributor

SergioEstevao commented Mar 31, 2020

@mchowning I still have hopes that you can have this available on 1.25, but if not please move it to the 1.26 milestone.

@mchowning mchowning modified the milestones: 1.25, 1.26 Mar 31, 2020
@pinarol pinarol modified the milestones: 1.26, 1.27 Apr 13, 2020
@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Apr 13, 2020

I am changing the milestone of this PR as 1.27 because the 1.26 release branch will be cut quite soon. Let me know if you instead wanted to include this to 1.26.

@mchowning mchowning mentioned this pull request Apr 22, 2020
Merged
6 tasks
@mchowning mchowning force-pushed the update_aztec_for_alignment branch 4 times, most recently from 719b019 to 6ac77c6 Compare April 23, 2020 18:47
@cameronvoell cameronvoell requested review from mkevins and removed request for mkevins April 24, 2020 02:31
@mchowning mchowning force-pushed the update_aztec_for_alignment branch from 6ac77c6 to 174dac2 Compare April 24, 2020 13:04
hypest
hypest approved these changes Apr 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good code-wise! I still haven't made a pass to test the behavior but I'll LGTM this and someone (or me) can do the testing pass.

@mchowning mchowning force-pushed the update_aztec_for_alignment branch 2 times, most recently from aabf1ce to 90dd372 Compare April 24, 2020 17:55
@mchowning mchowning mentioned this pull request Apr 24, 2020
Merged
3 tasks
@mchowning mchowning force-pushed the update_aztec_for_alignment branch from 90dd372 to c17064c Compare April 24, 2020 20:54
@mchowning mchowning merged commit 133be1e into develop Apr 24, 2020
@mchowning mchowning deleted the update_aztec_for_alignment branch April 24, 2020 21:18
@guarani guarani mentioned this pull request Apr 24, 2020
Closed
This was referenced Apr 27, 2020
Merged
Merged
Merged
@mchowning mchowning mentioned this pull request May 1, 2020
Closed
@designsimply designsimply mentioned this pull request May 14, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cameronvoell cameronvoell Awaiting requested review from cameronvoell

@marecar3 marecar3 Awaiting requested review from marecar3

1 more reviewer

@hypest hypest hypest approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SergioEstevao SergioEstevao

@mchowning mchowning

Labels

None yet

Projects

None yet

Milestone

1.27

Development

Successfully merging this pull request may close these issues.

5 participants

@mchowning @marecar3 @SergioEstevao @pinarol @hypest