Update project to use react-native-url-polyfill package for the URL class#1996
Merged
cameronvoell merged 3 commits intodevelopfrom Mar 12, 2020
Merged
Update project to use react-native-url-polyfill package for the URL class#1996cameronvoell merged 3 commits intodevelopfrom
cameronvoell merged 3 commits intodevelopfrom
Conversation
etoledom
approved these changes
Mar 11, 2020
Contributor
etoledom
left a comment
There was a problem hiding this comment.
Looking great! 🎉
So nice that the issue was solved.
Tested on Android and iOS, tests local and on CI are ✅ on gutnberg and gutenberg-mobile
Thank you @SergioEstevao !
charpeni
reviewed
Mar 11, 2020
| "react-native-modal": "^6.5.0", | ||
| "react-native-safe-area": "^0.5.0", | ||
| "react-native-svg": "git+https://github.com/wordpress-mobile/react-native-svg.git#a628e92990a2404e30a0086f168bd2b5b7b4ce96", | ||
| "react-native-url-polyfill": "^1.1.2", |
bd293fc to
49bed94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update project to use react-native-url-polyfill package for the URL class.
This is related to this Gutenberg PR that adds full test for the isURL method: WordPress/gutenberg#20537
To test:
@etoledom can you check that the build process error that you saw before no longer occurs?
PR submission checklist:
RELEASE-NOTES.txtif necessary.