Skip to content

Refactor the spacer block.#1991

Merged
SergioEstevao merged 5 commits intodevelopfrom
issue/refactor_spacer_block
Mar 12, 2020
Merged

Refactor the spacer block.#1991
SergioEstevao merged 5 commits intodevelopfrom
issue/refactor_spacer_block

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Mar 9, 2020 •
edited
Loading

Refactor the spacer block on mobile to have the same edit code as the web. All the work was done on the Gutenberg PR bellow:

Gutenberg PR: WordPress/gutenberg#20746

To test:

  • Start the demo app
  • Add a spacer block
  • Check if the block settings are working correctly and updating the block view.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added the [Type] Enhancement Improves a current area of the editor label Mar 9, 2020
@SergioEstevao SergioEstevao added this to the 1.24 milestone Mar 9, 2020
@SergioEstevao SergioEstevao requested a review from Tug March 9, 2020 21:42
@SergioEstevao SergioEstevao mentioned this pull request Mar 9, 2020
Merged
6 tasks
@SergioEstevao SergioEstevao changed the title Update gutenberg reference. Refactor the spacer block. Mar 9, 2020
Tug
Tug approved these changes Mar 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SergioEstevao SergioEstevao merged commit 9727278 into develop Mar 12, 2020
@SergioEstevao SergioEstevao deleted the issue/refactor_spacer_block branch March 12, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Tug Tug Tug approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Milestone

1.24

Development

Successfully merging this pull request may close these issues.

2 participants

@SergioEstevao @Tug