Add support for heading alignment buttons#1990
Merged
SergioEstevao merged 14 commits intodevelopfrom Mar 25, 2020
Merged
Conversation
Add emotion library to project to support styled Text component.
6 tasks
Contributor
|
Thank you for working on this! It'll be beneficial for a bunch of blocks/features <3 |
Contributor
Author
|
@mchowning is going to check why the align commands don't work on Android. |
1 task
Contributor
|
I have opened an AztecEditor-Android PR that should address the alignment issue we're seeing here on Android. |
Contributor
|
We're freezing |
# Conflicts: # gutenberg
# Conflicts: # gutenberg # react-native-aztec/android/build.gradle
Contributor
Author
|
I'm merging this PR and doing a follow up PR to disable the options to align in Android if Aztec Android is not until next Friday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1880
Gutenberg PR: WordPress/gutenberg#20745
This PR updates the GB reference to add support to alignment on the Heading block.
In the process, the heading block was refactored to share all the edit method with the web and that that involved using the new Text component that needed the adding of the emotion style library.
We now have support for dropdown menu in the block control. The implementation uses a BottomSheet to show the options when tapped.
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.