Skip to content

Fix: Remove extra space from BlockCaption#1971

Merged
jbinda merged 3 commits intodevelopfrom
callstack/fix-caption-padding-visibility
Mar 4, 2020
Merged

Fix: Remove extra space from BlockCaption#1971
jbinda merged 3 commits intodevelopfrom
callstack/fix-caption-padding-visibility

Conversation

@jbinda
Copy link
Copy Markdown
Contributor

@jbinda jbinda commented Feb 28, 2020

Fixes #1919

Please also refer to:
Related gutenberg PR
Related gutenberg-mobile issue

It presents:
Conditionally remove extra padding in BlockCaption when shouldVisible flag is set to false. Please check this comment for more datails

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jbinda jbinda merged commit 8796e8c into develop Mar 4, 2020
@jbinda jbinda deleted the callstack/fix-caption-padding-visibility branch March 4, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove additional padding below image on image block

2 participants