Skip to content

Video block - don't force full screen on iOS #1952

Merged
SergioEstevao merged 7 commits intodevelopfrom
issue/video_block_dont_force_fullscreen_on_ios
Apr 21, 2020
Merged

Video block - don't force full screen on iOS #1952
SergioEstevao merged 7 commits intodevelopfrom
issue/video_block_dont_force_fullscreen_on_ios

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Feb 25, 2020

Updates the video player to not force fullscreen on the iOS video block.

I also added a prop that allows the explicit setting of fullscreen mode when pressing play for iOS and Android. This can be helpful in the future for the Cover block.

GB PR: WordPress/gutenberg#20436

To test:

  • Run the demo app
  • on iOS check that the video on the demo doesn't go to fullscreen when pressing play
  • check if no layout issues happen
  • on Android check, if the video block still open on an external application
  • check if no layout issues happen

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added the [Type] Enhancement Improves a current area of the editor label Feb 25, 2020
@SergioEstevao SergioEstevao added this to the 1.24 milestone Feb 25, 2020
@SergioEstevao SergioEstevao mentioned this pull request Feb 25, 2020
Merged
6 tasks
@marecar3
Copy link
Copy Markdown
Contributor

marecar3 commented Mar 16, 2020

We're freezing 1.24.0 today. If you think it is ready and if you'd like to ship it with 1.24.0please merge it into develop branch. Otherwise, we can bump it to 1.25.0. @SergioEstevao

@hypest hypest modified the milestones: 1.24, 1.25 Mar 20, 2020
@hypest
Copy link
Copy Markdown
Contributor

hypest commented Mar 20, 2020

Bumped this to 1.25 as it's WIP.

@SergioEstevao SergioEstevao removed this from the 1.25 milestone Mar 31, 2020
@SergioEstevao SergioEstevao requested a review from ceyhun April 20, 2020 20:57
@SergioEstevao SergioEstevao added this to the 1.27 milestone Apr 20, 2020
@SergioEstevao
Copy link
Copy Markdown
Contributor Author

SergioEstevao commented Apr 20, 2020

@ceyhun do you mind giving a look to this one?

etoledom
etoledom approved these changes Apr 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#20436 (review)

@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Apr 21, 2020

Does this deserves a release note? 🤔

@SergioEstevao SergioEstevao merged commit dd36f68 into develop Apr 21, 2020
@SergioEstevao SergioEstevao deleted the issue/video_block_dont_force_fullscreen_on_ios branch April 21, 2020 11:37
This was referenced Apr 27, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinarol pinarol Awaiting requested review from pinarol

@ceyhun ceyhun Awaiting requested review from ceyhun

1 more reviewer

@etoledom etoledom etoledom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Milestone

1.27

Development

Successfully merging this pull request may close these issues.

4 participants

@SergioEstevao @marecar3 @hypest @etoledom