Skip to content

Project cleanup#1833

Merged
SergioEstevao merged 5 commits intodevelopfrom
issue/project_cleanup
Jan 29, 2020
Merged

Project cleanup#1833
SergioEstevao merged 5 commits intodevelopfrom
issue/project_cleanup

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

This PR cleans up some iOS project definitions to make the project cleaner on iOS. It also updates the initial content HTML to avoid transformation warnings on startup.

To test:

  • Make sure the app builds and runs.
  • Check the demo content.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Tested with yarn iOS and running from Xcode 👍

…d doing pod install.

For the cases you just changing local code and no pods are changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants