Skip to content

Update ref to react-native-slider fork to support autolinking#1826

Merged
lukewalczak merged 3 commits intodevelopfrom
update/react-native-slider
Jan 29, 2020
Merged

Update ref to react-native-slider fork to support autolinking#1826
lukewalczak merged 3 commits intodevelopfrom
update/react-native-slider

Conversation

@lukewalczak
Copy link
Copy Markdown
Contributor

@lukewalczak lukewalczak commented Jan 28, 2020 •
edited
Loading

Fixes app crash on opening settings within Spacer, because of missing RNCSlider after updating RN.

During the building process you could notice a warning:

[!] use_native_modules! skipped the react-native dependency '@react-native-community/slider'. No podspec file was found.

I assume that autolinking requires podspec file to be on the project root, but in react-native-slider is nested so I had to move up.

To test:

  1. remove old node_modules
  2. yarn clean:install
  3. yarn ios
  4. add a Spacer block
  5. open settings
  6. app mustn't crash!

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@lukewalczak lukewalczak self-assigned this Jan 28, 2020
@pinarol pinarol requested a review from chipsnyder January 28, 2020 15:56
@lukewalczak lukewalczak force-pushed the update/react-native-slider branch from 5ec78eb to fa58081 Compare January 28, 2020 19:05
@lukewalczak lukewalczak force-pushed the update/react-native-slider branch from 8bffb16 to 0a04f4f Compare January 28, 2020 19:30
chipsnyder
chipsnyder approved these changes Jan 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for taking care of this!

As a helpful note to others, I was getting a CocoaPods error, and I had to clear my Derived Data as well.

@lukewalczak lukewalczak force-pushed the update/react-native-slider branch from 0a04f4f to 2c4e38a Compare January 28, 2020 19:50
@lukewalczak lukewalczak merged commit d87988e into develop Jan 29, 2020
@lukewalczak lukewalczak deleted the update/react-native-slider branch January 29, 2020 08:54
@mkevins mkevins restored the update/react-native-slider branch February 3, 2020 00:55
This was referenced Feb 3, 2020
Merged
Merged
Merged
@mkevins mkevins deleted the update/react-native-slider branch July 6, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chipsnyder chipsnyder chipsnyder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukewalczak lukewalczak

Labels

bugfix [Type] Crash

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukewalczak @chipsnyder