Rename iOS module name of sample app from gutenberg to GutenbergDemo.#1820
Merged
SergioEstevao merged 4 commits intodevelopfrom Jan 27, 2020
Merged
Rename iOS module name of sample app from gutenberg to GutenbergDemo.#1820SergioEstevao merged 4 commits intodevelopfrom
SergioEstevao merged 4 commits intodevelopfrom
Conversation
This is to avoid conflicts with the pod Gutenberg.
2 tasks
koke
approved these changes
Jan 27, 2020
Member
koke
left a comment
There was a problem hiding this comment.
Makes sense, and seems to work fine after cleaning the build folder 👌
Contributor
|
👋 @SergioEstevao , as a follow up, do you think that we could/should also rename the local files that are still named as "gutenberg.xxx"? For example, all the files/folders in https://github.com/wordpress-mobile/gutenberg-mobile/tree/develop/ios are still named/prefixed |
This was referenced Feb 3, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the update to React 0.61.5 the iOS demo project is now built using CocoaPods.
This creates a scenario where sometimes Xcode build system gets confused between the pod library Gutenberg (the Gutenberg Bridge podspec) and the binary of the demo project itself: gutenberg.
You will see Xcode sometimes complaining that we are importing
Gutenberginstead ofgutenberg, and after getting on this state you will probably need to clean all build folders and restart the project.So the solution I propose here is to rename the module name of the
gutenberg.xcodeprojfromgutenbergtoGutenbergDemoto avoid these conflicts going forward.To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.