Added list block ordered button e2e test#1806
Conversation
hypest
left a comment
There was a problem hiding this comment.
LGTM!
Good to see the test failing after tapping the list type change button :). Here's the button tapping that causes the red screen, recorded in the Saucelabs testrun: https://app.saucelabs.com/tests/66b8b410d415402198d6ad4aae6cc010?auth=bdf07e59796c65673ac609ba29f25381#50
We could merge this PR but since the test will fail (by design), it will block all PRs that follow it until the fix is merged (currently merged only in the v1.21.0 release branches). I'd suggest we wait until after the release is merged back to develop. WDYT?
Agreed! I'll catch this PR back up with develop when the List Block fix is merged there, and consider this PR ready once CI all passes. |
|
Now that the the numbered list fix checked by this test is merged into develop, tests are passing on the PR, and the new test is ready to be merged to develop. |
This change should be merged to
developafter WordPress/gutenberg#19818 or a similar fix is merged intodevelp, otherwise the new test will (and should) fail.Background
Fixes #1805
WordPress/gutenberg#19818 fixed a crash on a release branch that was found from pressing the ordered list button on List Block that was caused by a change in Gutenberg (WordPress/gutenberg#19536).
Description
This change adds the ordered list button press to our Appium tests so any related issues will be caught in the future.
New Test:
__device-tests__/gutenberg-editor-lists.test.js
'should be able to add a new List block'
To test:
Run with
yarn test:e2e:ios:local gutenberg-editor-lists.test.jsandyarn test:e2e:android:local gutenberg-editor-lists.test.js*Note: this change should show a failed test on branches that do not yet include the fix from WordPress/gutenberg#19818, and it should pass on branches that have that fix.
PR submission checklist:
RELEASE-NOTES.txtif necessary.