Force the react-native-video fork to build against same RN version as gutenberg-mobile from maven repo#1768
Merged
hypest merged 4 commits intorelease/1.20.0from Jan 10, 2020
Conversation
Tug
approved these changes
Jan 10, 2020
Contributor
Tug
left a comment
There was a problem hiding this comment.
Can confirm, this revert fixes it for me 👍
Tug
approved these changes
Jan 10, 2020
Contributor
Tug
left a comment
There was a problem hiding this comment.
Still works with the last commit!
mchowning
approved these changes
Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 4085aeb.
Fixes #1761
It's not clear yet why the issue is happening but, reverting in order to patch and unblock the v1.20 editor release.
Edit: With 39f9f34, I'm pointing to a react-native-video version (here's the branch) that builds using a specific RN version (same as gutenberg-mobile at the moment of writing) and only fetching it from our remote RN maven mirror on Bintray.
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.